chrome/browser/ui/browser.cc - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 6f94a621c31e1a6b6ff5090f8619dd687e13cb08..1595e868001d614ce36dc7d5dc0e6cc947427210 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -61,6 +61,7 @@

#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/lifetime/application_lifetime.h"

+#include "chrome/browser/lifetime/keep_alive_registry.h"

#include "chrome/browser/memory/tab_manager_web_contents_data.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/pepper_broker_infobar_delegate.h"

@@ -701,7 +702,8 @@ void Browser::OnWindowClosing() {

// AppController on the Mac, or BackgroundContentsService for background

// pages).

bool should_quit_if_last_browser =

- browser_shutdown::IsTryingToQuit() || !chrome::WillKeepAlive();

+ browser_shutdown::IsTryingToQuit() ||

+ !KeepAliveRegistry::GetInstance()->IsKeepingAlive();

if (should_quit_if_last_browser && ShouldStartShutdown())

browser_shutdown::OnShutdownStarting(browser_shutdown::WINDOW_CLOSE);

« no previous file with comments | « chrome/browser/ui/ash/ash_init.cc ('k') | chrome/browser/ui/panels/panel.h » ('j') | no next file with comments »