Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3306)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver
Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index 39ccea2d014ad3e89694bc55a9de5339764168ec..d92d76cb44e649ab61844e0bb36a81b18f87f71f 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -19,7 +19,8 @@
#include "chrome/browser/content_settings/cookie_settings_factory.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/infobars/infobar_service.h"
-#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/lifetime/keep_alive_types.h"
+#include "chrome/browser/lifetime/scoped_keep_alive.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_impl.h"
@@ -317,8 +318,10 @@ class BetterSessionRestoreTest : public InProcessBrowserTest {
bool close_all_windows) {
Profile* profile = browser->profile();
+ ScopedKeepAlive test_keep_alive(KeepAliveOrigin::PANEL_VIEW,
+ KeepAliveRestartOption::DISABLED);
+
// Close the browser.
- chrome::IncrementKeepAliveCount();
if (close_all_windows)
CloseAllBrowsers();
else
@@ -334,7 +337,6 @@ class BetterSessionRestoreTest : public InProcessBrowserTest {
ui_test_utils::BrowserAddedObserver window_observer;
chrome::NewEmptyWindow(profile);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
- chrome::DecrementKeepAliveCount();
return new_browser;
}
« no previous file with comments | « chrome/browser/lifetime/keep_alive_types.cc ('k') | chrome/browser/ui/app_list/app_list_service_views_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698