chrome/browser/chromeos/login/login_browsertest.cc - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_browsertest.cc

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_process_platform_part_chromeos.cc ('k') | chrome/browser/chromeos/login/ui/login_display_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/login_browsertest.cc

diff --git a/chrome/browser/chromeos/login/login_browsertest.cc b/chrome/browser/chromeos/login/login_browsertest.cc

index bd7b287a889082eb3bad83c6c913bd5954c8eb1e..4d57ef6a3b34b66b10e38e5f8ff073468904322c 100644

--- a/chrome/browser/chromeos/login/login_browsertest.cc

+++ b/chrome/browser/chromeos/login/login_browsertest.cc

@@ -75,6 +75,12 @@ class LoginSigninTest : public InProcessBrowserTest {

command_line->AppendSwitch(switches::kForceLoginManagerInTests);

}

+ void TearDownOnMainThread() override {

+ // Close the login manager, which otherwise holds a KeepAlive that is not

+ // cleared in time by the end of the test.

+ LoginDisplayHost::default_host()->Finalize();

+ }

void SetUpOnMainThread() override {

LoginDisplayHostImpl::DisableRestrictiveProxyCheckForTest();