chrome/browser/browser_process_impl.cc - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_mode_manager_unittest.cc ('k') | chrome/browser/browser_process_platform_part_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_process_impl.cc

diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc

index d1b356c1e7359db413294cafc025dd9bd3b72236..9acabd15fea8b00735f2ac854f11871732509887 100644

--- a/chrome/browser/browser_process_impl.cc

+++ b/chrome/browser/browser_process_impl.cc

@@ -46,6 +46,7 @@

#include "chrome/browser/intranet_redirect_detector.h"

#include "chrome/browser/io_thread.h"

#include "chrome/browser/lifetime/application_lifetime.h"

+#include "chrome/browser/lifetime/keep_alive_registry.h"

#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"

#include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"

#include "chrome/browser/metrics/thread_watcher.h"

@@ -1251,7 +1252,8 @@ void BrowserProcessImpl::CacheDefaultWebClientState() {

bool BrowserProcessImpl::CanAutorestartForUpdate() const {

// Check if browser is in the background and if it needs to be restarted to

// apply a pending update.

- return chrome::GetTotalBrowserCount() == 0 && chrome::WillKeepAlive() &&

+ return chrome::GetTotalBrowserCount() == 0 &&

+ KeepAliveRegistry::GetInstance()->IsKeepingAlive() &&

upgrade_util::IsUpdatePendingRestart();

}