chrome/browser/devtools/devtools_sanity_browsertest.cc - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: remove registry destructor dchecks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/login_browsertest.cc ('K') | « chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('k') | chrome/browser/lifetime/application_lifetime.h » ('j') | chrome/browser/lifetime/keep_alive_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_sanity_browsertest.cc

diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc

index 62b3284bce8931490d4e61dc68e21ab6eb4a1116..2613d684f3773d15e91d2251abbd2152cc64ca04 100644

--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc

+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc

@@ -771,7 +771,6 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,

content::WindowedNotificationObserver close_observer(

chrome::NOTIFICATION_BROWSER_CLOSED,

content::Source<Browser>(browser()));

- chrome::IncrementKeepAliveCount();

chrome::CloseAllBrowsers();

AcceptModalDialog();