content/renderer/android/synchronous_compositor_external_begin_frame_source.cc - Issue 1778853003: Fold BeginFrameSource::SetClientReady into AddObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/android/synchronous_compositor_external_begin_frame_source.cc

Issue 1778853003: Fold BeginFrameSource::SetClientReady into AddObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_always_external

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/android/synchronous_compositor_external_begin_frame_source.h ('k') | content/renderer/gpu/compositor_external_begin_frame_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/android/synchronous_compositor_external_begin_frame_source.cc

diff --git a/content/renderer/android/synchronous_compositor_external_begin_frame_source.cc b/content/renderer/android/synchronous_compositor_external_begin_frame_source.cc

index 1ff765a33a6fa435173137879c9d293f2f1d2860..7bb1dc8f72766b7cd80aa24b8c595003a93934e8 100644

--- a/content/renderer/android/synchronous_compositor_external_begin_frame_source.cc

+++ b/content/renderer/android/synchronous_compositor_external_begin_frame_source.cc

@@ -61,8 +61,12 @@ void SynchronousCompositorExternalBeginFrameSource::OnNeedsBeginFramesChanged(

client_->OnNeedsBeginFramesChange(needs_begin_frames);

}

-void SynchronousCompositorExternalBeginFrameSource::SetClientReady() {

+void SynchronousCompositorExternalBeginFrameSource::AddObserver(

+ cc::BeginFrameObserver* obs) {

DCHECK(CalledOnValidThread());

+ BeginFrameSourceBase::AddObserver(obs);

+ if (registered_)

+ return;

registry_->RegisterBeginFrameSource(routing_id_, this);

registered_ = true;

}