cc/scheduler/begin_frame_source.h - Issue 1778853003: Fold BeginFrameSource::SetClientReady into AddObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 1778853003: Fold BeginFrameSource::SetClientReady into AddObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_always_external

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/begin_frame_source.h

diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h

index 6815d4285ff7e1cb62303404143e43b793305c17..1efd6a1bda6d22d8b333de632e66780eb00caabf 100644

--- a/cc/scheduler/begin_frame_source.h

+++ b/cc/scheduler/begin_frame_source.h

@@ -126,9 +126,6 @@ class CC_EXPORT BeginFrameSource {

virtual void AddObserver(BeginFrameObserver* obs) = 0;

virtual void RemoveObserver(BeginFrameObserver* obs) = 0;

- // Tells the Source that client is ready to handle BeginFrames messages.

- virtual void SetClientReady() = 0;

// Tracing support - Recommend (but not required) to call this implementation

// in any override.

virtual void AsValueInto(base::trace_event::TracedValue* dict) const = 0;

@@ -149,7 +146,6 @@ class CC_EXPORT BeginFrameSourceBase : public BeginFrameSource {

void DidFinishFrame(size_t remaining_frames) override {}

void AddObserver(BeginFrameObserver* obs) override;

void RemoveObserver(BeginFrameObserver* obs) override;

- void SetClientReady() override {}

// Tracing support - Recommend (but not required) to call this implementation

// in any override.

« no previous file with comments | « no previous file | cc/scheduler/scheduler.cc » ('j') | no next file with comments »