third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/blue-100x50.png ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index a62fd6cf83df205e2e464820cd4f7296f8d5d0bb..489457ece9f103a000e78a2ab99e37a034dcda1d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -168,10 +168,6 @@ private:

void paintChildren(const PaintInfo&, const LayoutPoint&) const override;

- bool needToStretchChildLogicalHeight(const LayoutBox&) const;

- LayoutUnit childIntrinsicHeight(const LayoutBox&) const;

- LayoutUnit childIntrinsicWidth(const LayoutBox&) const;

- LayoutUnit intrinsicLogicalHeightForChild(const LayoutBox&) const;

LayoutUnit marginLogicalHeightForChild(const LayoutBox&) const;

LayoutUnit computeMarginLogicalHeightForChild(const LayoutBox&) const;

LayoutUnit availableAlignmentSpaceForChildBeforeStretching(LayoutUnit gridAreaBreadthForChild, const LayoutBox&) const;