Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html

Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted unneeded changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/blue-100x50.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html
new file mode 100644
index 0000000000000000000000000000000000000000..8b3938bd2e3f193652dd559ed66b2385ae9249dd
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html
@@ -0,0 +1,77 @@
+<!DOCTYPE html>
+<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel="stylesheet">
+<style>
+.container {
+ border: 5px solid orange;
+ display: grid;
+}
+</style>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../../resources/check-layout-th.js"></script>
+
+<body onload="checkLayout('.container')">
+<div id="log"></div>
+
+<p>This test shows how min-width|height:auto is computed for items with intrinisc aspect ratios</p>
+
+<p>Check that width respects the intrinsic aspect ratio when specifying the height</p>
+<div class="container min-content" data-expected-width="60" data-expected-height="35">
Manuel Rego 2016/03/21 12:13:29 Nit: dunno if we want to check the size of the gri
svillar 2016/03/21 13:22:27 I do want to check them because as you could see,
+ <img src="resources/blue-100x50.png" style="height: 25px;" data-expected-width="50" data-expected-height="25"/>
+</div>
+
+<div class="container min-content" data-expected-width="150" data-expected-height="80">
+ <img src="resources/blue-100x50.png" style="min-height: 70px;" data-expected-width="140" data-expected-height="70"/>
+</div>
+
+<div class="container min-content" data-expected-width="110" data-expected-height="60">
+ <img src="resources/blue-100x50.png" style="max-height: 50px;" data-expected-width="100" data-expected-height="50"/>
Manuel Rego 2016/03/21 12:13:29 Nit: "max-height: 50px" is not really useful, what
svillar 2016/03/21 13:22:27 good point
+</div>
+
+<div class="container min-content" data-expected-width="70" data-expected-height="40">
+ <img src="resources/blue-100x50.png" style="height: 25px; min-height: 30px;" data-expected-width="60" data-expected-height="30"/>
+</div>
+
+<div class="container min-content" data-expected-width="30" data-expected-height="20">
+ <img src="resources/blue-100x50.png" style="height: 25px; max-height: 10px;" data-expected-width="20" data-expected-height="10"/>
+</div>
+
+<div class="container min-content" data-expected-width="50" data-expected-height="35">
+ <img src="resources/blue-100x50.png" style="height: 25px; max-width: 40px;" data-expected-width="40" data-expected-height="25"/>
+</div>
+
+<div class="container min-content" data-expected-width="60" data-expected-height="40">
+ <img src="resources/blue-100x50.png" style="height: 25px; min-height: 30px; max-width: 50px;" data-expected-width="50" data-expected-height="30"/>
+</div>
+
+
+<p>Check that height respects the intrinsic aspect ratio when specifying the width</p>
+<div class="container min-content" data-expected-width="60" data-expected-height="35">
+ <img src="resources/blue-100x50.png" style="width: 50px;" data-expected-width="50" data-expected-height="25"/>
+</div>
+
+<div class="container min-content" data-expected-width="70" data-expected-height="40">
+ <img src="resources/blue-100x50.png" style="max-width: 60px;" data-expected-width="60" data-expected-height="30"/>
+</div>
+
+<div class="container min-content" data-expected-width="130" data-expected-height="70">
+ <img src="resources/blue-100x50.png" style="min-width: 120px;" data-expected-width="120" data-expected-height="60"/>
+</div>
+
+<div class="container min-content" data-expected-width="90" data-expected-height="50">
+ <img src="resources/blue-100x50.png" style="width: 60px; min-width: 80px;" data-expected-width="80" data-expected-height="40"/>
+</div>
+
+<div class="container min-content" data-expected-width="34" data-expected-height="22">
+ <img src="resources/blue-100x50.png" style="width: 24px; max-width: 40px;" data-expected-width="24" data-expected-height="12"/>
+</div>
+
+<div class="container min-content" data-expected-width="110" data-expected-height="35">
+ <img src="resources/blue-100x50.png" style="width: 100px; max-height: 25px;" data-expected-width="100" data-expected-height="25"/>
Manuel Rego 2016/03/21 12:13:29 Nit: "width: 100px" maybe better "width: 120px".
svillar 2016/03/21 13:22:28 Another good point.
+</div>
+
+<div class="container min-content" data-expected-width="35" data-expected-height="110">
+ <img src="resources/blue-100x50.png" style="width: 25px; min-height: 100px;" data-expected-width="25" data-expected-height="100"/>
+</div>
+
+</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/blue-100x50.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698