third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/100x50.png ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index 2b8a16c784d9e96496214e0343ab94e17425bc52..14a91415faa345d7a970eed98a65f0dea00812c6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -186,7 +186,8 @@ private:

#endif

size_t gridItemSpan(const LayoutBox&, GridTrackSizingDirection);

- bool spanningItemCrossesFlexibleSizedTracks(const GridSpan&, GridTrackSizingDirection) const;

+ enum SpanMode { FlexibleOnly, ContentSizedAndFlexible };

Manuel Rego 2016/03/14 14:38:09 Maybe call it SpanTracksMode. Dunno really, but tr

svillar 2016/03/17 13:33:54 I wasn't able to find a good name. I can change it

+ bool itemSpansContentSizedOrFlexibleSizedTracks(const GridSpan&, GridTrackSizingDirection, SpanMode) const;

size_t gridColumnCount() const

{