Issue 177883002: Fix crasher in Object.getOwnPropertySymbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177883002: Fix crasher in Object.getOwnPropertySymbols (Closed)

Created:
6 years, 10 months ago by rossberg

Modified:
6 years, 10 months ago

Reviewers:
arv (Not doing code reviews), Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix crasher in Object.getOwnPropertySymbols R=arv@chromium.org, mstarzinger@chromium.org BUG=346141 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=19539

Patch Set 2 : Comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -16 lines)			Patch
	M	src/objects.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-346141.js	View		1 chunk	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://codereview.chromium.org/177883002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/177883002/diff/1/src/objects.cc#newcode15523 src/objects.cc:15523: if (HashTable<Shape, Key>::IsKey(k)) { Shouldn't the fix also apply ...

6 years, 10 months ago (2014-02-24 14:23:40 UTC) #2

rossberg

6 years, 10 months ago (2014-02-24 14:42:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19539.

Expand Messages | Collapse Messages

Issue 177883002: Fix crasher in Object.getOwnPropertySymbols (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comments #

Messages