Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1778773003: Change the order of Platform::initialize and WTF::initialize (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the order of Platform::initialize and WTF::initialize Previously there was a strange dependency between platform and wtf (around setCurrentTimeFunction) and we couldn't initialize wtf before platform. Now the dependency is gone (https://codereview.chromium.org/1550563002/). We can initialize in the order of wtf => platform, and shutdown in the order of platform => wtf. BUG=593269 Committed: https://crrev.com/46eaaf1c1504445b80015794296b2ca2dcb9dcb1 Cr-Commit-Position: refs/heads/master@{#380295}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/web/WebKit.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-09 12:33:25 UTC) #2
sof
lgtm https://codereview.chromium.org/1778773003/diff/1/third_party/WebKit/Source/web/WebKit.cpp File third_party/WebKit/Source/web/WebKit.cpp (right): https://codereview.chromium.org/1778773003/diff/1/third_party/WebKit/Source/web/WebKit.cpp#newcode159 third_party/WebKit/Source/web/WebKit.cpp:159: ASSERT(platform); nit: keep this assert alongside the platform ...
4 years, 9 months ago (2016-03-09 19:07:52 UTC) #3
haraken
> https://codereview.chromium.org/1778773003/diff/1/third_party/WebKit/Source/web/WebKit.cpp > File third_party/WebKit/Source/web/WebKit.cpp (right): > > https://codereview.chromium.org/1778773003/diff/1/third_party/WebKit/Source/web/WebKit.cpp#newcode159 > third_party/WebKit/Source/web/WebKit.cpp:159: ASSERT(platform); > nit: keep ...
4 years, 9 months ago (2016-03-09 23:42:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778773003/20001
4 years, 9 months ago (2016-03-09 23:42:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 01:43:33 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 01:47:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46eaaf1c1504445b80015794296b2ca2dcb9dcb1
Cr-Commit-Position: refs/heads/master@{#380295}

Powered by Google App Engine
This is Rietveld 408576698