third_party/WebKit/Source/bindings/templates/interface_base.cpp - Issue 1778773002: [bindings] remove @@iterator from Window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 1778773002: [bindings] remove @@iterator from Window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on top of shipping CL Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/iterator-expected.txt ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

index 3ee994a8caa6bdec749b5ef1dc064f0cb06b8071..1ab63c2258c159c836a5abc2f53a902eeea4460e 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

@@ -333,14 +333,10 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> interfac

instanceTemplate->SetAccessCheckCallback({{cpp_class}}V8Internal::securityCheck, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo)));

{% endif %}

- {%- if has_array_iterator %}{{newline}}

+ {%- if has_array_iterator and not is_global %}{{newline}}

// Array iterator

- {% if is_global %}

- instanceTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);

- {% else %}

prototypeTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);

{% endif %}

- {% endif %}

{%- set runtime_enabled_features = dict() %}

{% for attribute in attributes