third_party/WebKit/LayoutTests/fast/events/page-visibility-iframe-unload.html - Issue 1778753003: Fire visibilitychange event on unload (behind the flag)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/page-visibility-iframe-unload.html

Issue 1778753003: Fire visibilitychange event on unload (behind the flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix + one more test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/page-visibility-iframe-delete-test.html ('k') | third_party/WebKit/LayoutTests/fast/events/page-visibility-iframe-unload-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <script src="../../resources/js-test.js"></script>

	4 <script>

	5 description("This test checks that the page visibility event is fired when frame is unloaded.");

	6

	7 var jsTestIsAsync = true;

	8 var frames = [];

	9 var docsLoaded = 0, visibilityChanged = 0;

	10 var numFrames = 3;

	11

	12 function startTest() {
	dcheng 2016/03/11 09:13:36 window.addEventListener('load', function () { /* window.addEventListener('load', function () { /* body of startTest / }); Then we won't need to count docsLoaded (and iframe onload won't have to call back up here) Oh… this shares the test files with page-visibility-iframe-delete-test.html, I see. Well, it might be nice cleanup, but I guess let's just do it in a followup CL since it involves more changes to fast/events/page-visibility-iframe-delete-test.html. kinuko* 2016/03/11 12:55:13 Yup, I figured out that this wouldn't be the simpl Show quoted text On 2016/03/11 09:13:36, dcheng wrote: > window.addEventListener('load', function () { > /* body of startTest */ > }); > > Then we won't need to count docsLoaded (and iframe onload won't have to call > back up here) > > Oh… this shares the test files with page-visibility-iframe-delete-test.html, I > see. > > Well, it might be nice cleanup, but I guess let's just do it in a followup CL > since it involves more changes to > fast/events/page-visibility-iframe-delete-test.html. Yup, I figured out that this wouldn't be the simplest code to do this. I'll make a follow-up CL
	13 if (++docsLoaded < numFrames)

	14 return;

	15

	16 debug("Loaded all frames.");

	17

	18 frames.push(document.getElementById("frame1"));
	dcheng 2016/03/11 09:13:37 window[0] window[0]
	19 frames.push(frame1.contentDocument.getElementById("subIframe1"));
	dcheng 2016/03/11 09:13:36 window[0][0] window[0][0]
	20 frames.push(frame1.contentDocument.getElementById("subIframe2"));
	dcheng 2016/03/11 09:13:37 window[0][1] window[0][1]
	21

	22 for (var i = 0; i < frames.length; ++i) {

	23 frames[i].contentDocument.addEventListener(
	dcheng 2016/03/11 09:13:36 Then you can just use frames[i].document Then you can just use frames[i].document kinuko 2016/03/11 12:55:13 cool, done. Show quoted text On 2016/03/11 09:13:36, dcheng wrote: > Then you can just use frames[i].document cool, done.
	24 "visibilitychange",

	25 onVisibilityChange.bind(null, i), false);

	26 }

	27

	28 document.body.removeChild(frames[0]);

	29 }

	30

	31 function onVisibilityChange(i) {

	32 shouldBe('frames[' + i + '].contentDocument.visibilityState', '"hidden"');

	33 if (++visibilityChanged == numFrames)

	34 finishJSTest();

	35 }

	36

	37 </script>

	38 <iframe id="frame1" src="resources/page-visibility-iframe-with-subframes.html">< /iframe>

	39 </body>

	40 </html>

OLD	NEW