Fire visibilitychange event on unload (behind the flag)

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 846 matching lines @@
     return m_webView->pagePopupWindow();
 }
 
 bool ChromeClientImpl::shouldOpenModalDialogDuringPageDismissal(const DialogType& dialogType, const String& dialogMessage, Document::PageDismissalType dismissalType) const
 {
     const char* const kDialogs[] = { "alert", "confirm", "prompt" };
     int dialog = static_cast<int>(dialogType);
     ASSERT_WITH_SECURITY_IMPLICATION(0 <= dialog);
     ASSERT_WITH_SECURITY_IMPLICATION(dialog < static_cast<int>(WTF_ARRAY_LENGTH(kDialogs)));
 
-    const char* const kDismissals[] = { "beforeunload", "pagehide", "unload" };
+    // This array must be consistent with PageDismissalType enum defined in

[dcheng, 2016/03/11 04:20:38]

Do we need to preserve the relative order? This is currently logged in UMA. That
being said, I think the UMA stat is not very useful at this point. So maybe we
should just remove the UMA recording for this?

[kinuko, 2016/03/11 05:12:50]

Hmm, true. I removed the UMA part & changed these arrays into switch/case.  How
does it look to you now?

Also-- assuming that this patch's not looking terrible I'm going to add a few
more tests & start preparing intent process!

+    // Document.h.
+    const char* const kDismissals[] = { "beforeunload", "pagehide", "visibilitychange", "unload" };
     int dismissal = static_cast<int>(dismissalType) - 1; // Exclude NoDismissal.
     ASSERT_WITH_SECURITY_IMPLICATION(0 <= dismissal);
     ASSERT_WITH_SECURITY_IMPLICATION(dismissal < static_cast<int>(WTF_ARRAY_LENGTH(kDismissals)));
 
     DEFINE_STATIC_LOCAL(EnumerationHistogram, dialogDismissalHistogram, ("Renderer.ModalDialogsDuringPageDismissal", WTF_ARRAY_LENGTH(kDialogs) * WTF_ARRAY_LENGTH(kDismissals)));
     dialogDismissalHistogram.count(dismissal * WTF_ARRAY_LENGTH(kDialogs) + dialog);
 
     String message = String("Blocked ") + kDialogs[dialog] + "('" + dialogMessage + "') during " + kDismissals[dismissal] + ".";
     m_webView->mainFrame()->addMessageToConsole(WebConsoleMessage(WebConsoleMessage::LevelError, message));
 
@@ skipping 180 matching lines @@
     if (m_webView->pageImportanceSignals())
         m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript();
 }
 
 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler()
 {
     return m_webView->scheduler()->createFrameScheduler().release();
 }
 
 } // namespace blink