Fire visibilitychange event on unload (behind the flag)

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 1348 matching lines @@
 }
 
 PageVisibilityState Document::pageVisibilityState() const
 {
     // The visibility of the document is inherited from the visibility of the
     // page. If there is no page associated with the document, we will assume
     // that the page is hidden, as specified by the spec:
     // http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html#dom-document-hidden
     if (!m_frame || !m_frame->page())
         return PageVisibilityStateHidden;
+    // While visibilitychange is being dispatched during unloading it is
+    // expected that the visibility is hidden regardless of the page's
+    // visibility.
+    if (m_loadEventProgress == UnloadVisibilityChangeInProgress)
+        return PageVisibilityStateHidden;

[dcheng, 2016/03/10 22:46:33]

I think we should update pageDismissalEventBeingDispatched(): otherwise
document.open() in visibilitychange can change m_loadEventProgress back to
LoadEventNotRun.

(Actually the spec says we should completely ignore document.open during unload
but I haven't had time to fix that yet: see https://crbug.com/583586)

[kinuko, 2016/03/11 04:13:05]

Oh yeah we should.  Done.

     return m_frame->page()->visibilityState();
 }
 
 String Document::visibilityState() const
 {
     return pageVisibilityStateString(pageVisibilityState());
 }
 
 bool Document::hidden() const
 {
@@ skipping 1393 matching lines @@
         Element* currentFocusedElement = focusedElement();
         if (isHTMLInputElement(currentFocusedElement))
             toHTMLInputElement(*currentFocusedElement).endEditing();
         if (m_loadEventProgress < PageHideInProgress) {
             m_loadEventProgress = PageHideInProgress;
             if (LocalDOMWindow* window = domWindow())
                 window->dispatchEvent(PageTransitionEvent::create(EventTypeNames::pagehide, false), this);
             if (!m_frame)
                 return;
 
+            PageVisibilityState visibilityState = pageVisibilityState();
+            m_loadEventProgress = UnloadVisibilityChangeInProgress;
+            if (visibilityState != PageVisibilityStateHidden && RuntimeEnabledFeatures::visibilityChangeOnUnloadEnabled()) {
+                // Dispatch visibilitychange event, but don't bother doing
+                // other notifications as we're about to be unloaded.
+                dispatchEvent(Event::createBubble(EventTypeNames::visibilitychange));
+                dispatchEvent(Event::createBubble(EventTypeNames::webkitvisibilitychange));
+            }
+            if (!m_frame)
+                return;
+
             // The DocumentLoader (and thus its DocumentLoadTiming) might get destroyed
             // while dispatching the event, so protect it to prevent writing the end
             // time into freed memory.
             RefPtrWillBeRawPtr<DocumentLoader> documentLoader = m_frame->loader().provisionalDocumentLoader();
             m_loadEventProgress = UnloadEventInProgress;
             RefPtrWillBeRawPtr<Event> unloadEvent(Event::create(EventTypeNames::unload));
             if (documentLoader && !documentLoader->timing().unloadEventStart() && !documentLoader->timing().unloadEventEnd()) {
                 DocumentLoadTiming& timing = documentLoader->timing();
                 ASSERT(timing.navigationStart());
                 timing.markUnloadEventStart();
@@ skipping 3203 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     Document::WeakDocumentSet& set = Document::liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().getString().utf8().data());
 }
 #endif