third_party/WebKit/Source/core/editing/EditingStyle.cpp - Issue 1778743003: Make <custom-ident> not insert quotes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.cpp

Issue 1778743003: Make <custom-ident> not insert quotes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix FontFace.cpp Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingStyle.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.cpp b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

index 35f4e07513054312749d1fd443faaa7400703ccf..276a373618851ca7e5b2e4a72ca4306ca9adba9b 100644

--- a/third_party/WebKit/Source/core/editing/EditingStyle.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

@@ -1559,7 +1559,7 @@ void StyleChange::extractTextStyles(Document* document, MutableStylePropertySet*

m_applyFontFace = style->getPropertyValue(CSSPropertyFontFamily);

// Remove single quotes for Outlook 2007 compatibility. See https://bugs.webkit.org/show_bug.cgi?id=79448

Timothy Loh 2016/03/14 23:25:11 single -> double?

rwlbuis 2016/03/15 18:34:15 Done.

- m_applyFontFace.replaceWithLiteral('\'', "");

+ m_applyFontFace.replaceWithLiteral('\"', "");

Timothy Loh 2016/03/14 23:25:11 no need for backslash

rwlbuis 2016/03/15 18:34:15 Done.

style->removeProperty(CSSPropertyFontFamily);

if (RefPtrWillBeRawPtr<CSSValue> fontSize = style->getPropertyCSSValue(CSSPropertyFontSize)) {