Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

Issue 1778743003: Make <custom-ident> not insert quotes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also fix FontFace.cpp Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp
index f8f4e3a1e4f9a1413000857eafe99085b40e687c..8affd972e26658437f05a3d13ac728acbbb1d426 100644
--- a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp
@@ -5,6 +5,7 @@
#include "core/css/CSSCustomIdentValue.h"
#include "core/css/CSSMarkup.h"
+#include "core/css/DOMWindowCSS.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -27,7 +28,7 @@ String CSSCustomIdentValue::customCSSText() const
{
if (isKnownPropertyID())
return getPropertyNameAtomicString(m_propertyId);
- return quoteCSSStringIfNeeded(m_string);
+ return DOMWindowCSS::escape(m_string);
Timothy Loh 2016/03/14 23:25:11 IMO we should call the underlying conversion funct
rwlbuis 2016/03/15 18:34:15 Done.
}
DEFINE_TRACE_AFTER_DISPATCH(CSSCustomIdentValue)

Powered by Google App Engine
This is Rietveld 408576698