Issue 177873002: RTCPeerConnection: remove redundant throwing for callback args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177873002: RTCPeerConnection: remove redundant throwing for callback args. (Closed)

Created:
6 years, 10 months ago by sof

Modified:
6 years, 10 months ago

Reviewers:
Tommy Widenflycht, Mike West

CC:
blink-reviews, tommyw+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

RTCPeerConnection: remove redundant throwing for callback args. The generated binding code checks that the callback arguments are callable, reporting the required TypeError. Hence, implementation methods can simply assume that the supplied callback argument is valid. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167692

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
	M	Source/modules/mediastream/RTCPeerConnection.cpp	View		3 chunks	+4 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. Identical checks to what was removed in https://codereview.chromium.org/173893009

6 years, 10 months ago (2014-02-24 13:41:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/177873002/1

6 years, 10 months ago (2014-02-24 13:51:37 UTC) #4

Mike West

LGTM2, assuming the bots are happy (especially linux_blink, since ASSERT only does anything in debug).

6 years, 10 months ago (2014-02-24 13:52:17 UTC) #5

Message was sent while issue was closed.

Change committed as 167692

Expand Messages | Collapse Messages