Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1778713004: No need for ListHashSet<> in FrameSerializer. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
haraken, tkent
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need for ListHashSet<> in FrameSerializer. Insertion ordering isn't made use of. R=haraken BUG= Committed: https://crrev.com/0ccdfd000c205702b8912a446d92b0e0c2dff2e7 Cr-Commit-Position: refs/heads/master@{#380112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/FrameSerializer.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-09 09:20:47 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-03-09 09:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778713004/1
4 years, 9 months ago (2016-03-09 10:10:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 10:15:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 10:16:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ccdfd000c205702b8912a446d92b0e0c2dff2e7
Cr-Commit-Position: refs/heads/master@{#380112}

Powered by Google App Engine
This is Rietveld 408576698