Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1778693004: Set the current input context handler when the toplevel window is activated instead of when the inp… (Closed)

Created:
4 years, 9 months ago by Shu Chen
Modified:
4 years, 9 months ago
Reviewers:
James Su, Azure Wei
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the current input context handler when the toplevel window is activated instead of when the input field is focused. When the input field is focused, the top level window may not be active. For example, the IME window inactivatable, however, the embedded web contents has its own window and tries to set the focused text input client when it recieves the mouse down events. BUG=517773, 592976 Committed: https://crrev.com/772101175f0445dd93990a5f3c169ec62def9710 Cr-Commit-Position: refs/heads/master@{#380081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M ui/base/ime/input_method_base.cc View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Shu Chen
Please review this cl. Thanks. suzhe@ for committer approval.
4 years, 9 months ago (2016-03-09 03:41:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693004/1
4 years, 9 months ago (2016-03-09 03:57:36 UTC) #4
Azure Wei
lgtm
4 years, 9 months ago (2016-03-09 03:58:07 UTC) #5
James Su
lgtm
4 years, 9 months ago (2016-03-09 04:03:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 05:51:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693004/1
4 years, 9 months ago (2016-03-09 05:52:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 05:56:52 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 05:57:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/772101175f0445dd93990a5f3c169ec62def9710
Cr-Commit-Position: refs/heads/master@{#380081}

Powered by Google App Engine
This is Rietveld 408576698