Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1778683005: Drop remaining [LegacyInterfaceTypeChecking] for Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/text-layout-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Selection.idl
diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl
index e2c3a23f2871f237502a5efadad8dbab2341e84b..7466f32cdc6097f12862a8a37aec5d8706474652 100644
--- a/third_party/WebKit/Source/core/editing/Selection.idl
+++ b/third_party/WebKit/Source/core/editing/Selection.idl
@@ -47,18 +47,18 @@
//void removeRange(Range range);
[MeasureAs=SelectionRemoveAllRanges] void removeAllRanges();
[MeasureAs=SelectionEmpty] void empty();
- [MeasureAs=SelectionCollapse, RaisesException, LegacyInterfaceTypeChecking] void collapse(Node? node, optional long offset = 0);
- [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, LegacyInterfaceTypeChecking] void setPosition(Node? node, optional long offset = 0);
+ [MeasureAs=SelectionCollapse, RaisesException] void collapse(Node? node, optional long offset = 0);
+ [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional long offset = 0);
[MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();
[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
[MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);
// TODO(philipj): The arguments should be anchorNode, anchorOffset,
// focusNode and focusOffset, and none of them are optional or nullable in
// the spec.
- [MeasureAs=SelectionSetBaseAndExtent, RaisesException, LegacyInterfaceTypeChecking] void setBaseAndExtent([Default=Undefined] optional Node? baseNode,
- [Default=Undefined] optional long baseOffset,
- [Default=Undefined] optional Node? extentNode,
- [Default=Undefined] optional long extentOffset);
+ [MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent([Default=Undefined] optional Node? baseNode,
+ [Default=Undefined] optional long baseOffset,
+ [Default=Undefined] optional Node? extentNode,
+ [Default=Undefined] optional long extentOffset);
[MeasureAs=SelectionSelectAllChildren, RaisesException] void selectAllChildren(Node node);
[MeasureAs=SelectionDeleteDromDocument, CustomElementCallbacks] void deleteFromDocument();
[MeasureAs=SelectionContainsNode] boolean containsNode(Node node, optional boolean allowPartialContainment = false);
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/text-layout-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698