third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html - Issue 1778683005: Drop remaining [LegacyInterfaceTypeChecking] for Selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

Issue 1778683005: Drop remaining [LegacyInterfaceTypeChecking] for Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-copy-treeoutline.html ('k') | third_party/WebKit/LayoutTests/platform/win/editing/execCommand/indent-pre-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

index d1f84d9ed68c93d2155a164d2f1691331881580f..1eedad3656b25543173e8a710f86842058ab27fb 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

@@ -171,8 +171,8 @@ function test()

viewport.forceScrollItemToBeFirst(0);

// Set some initial selection in console.

- var base = consoleView.itemElement(messagesCount - 2);

- var extent = consoleView.itemElement(messagesCount - 1);

+ var base = consoleView.itemElement(messagesCount - 2).element();

+ var extent = consoleView.itemElement(messagesCount - 1).element();

window.getSelection().setBaseAndExtent(base, 0, extent, 0);

// Try to select all messages.