Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html

Issue 1778683005: Drop remaining [LegacyInterfaceTypeChecking] for Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/editing/execCommand/indent-pre-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html
diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html b/third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html
index 3cd0c5169573bb12eaa4d7980247b9b4ef057ab1..eba0a0bff57e3da8d15f28607590e74792d53a64 100644
--- a/third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html
+++ b/third_party/WebKit/LayoutTests/editing/execCommand/indent-pre.html
@@ -30,7 +30,7 @@ function setSelection(node)
var textNode = node.firstChild;
if (textNode.nodeType != Node.TEXT_NODE)
throw "Wrong node type: " + textNode;
- execSetSelectionCommand(textNode, 0, 0);
+ execSetSelectionCommand(textNode, 0, textNode, 0);
}
function verifyTextSelection(startNode, startOffset, endNode, endOffset)
@@ -87,7 +87,7 @@ setSelection(pre);
execMoveSelectionForwardByLineCommand();
execExtendSelectionForwardByLineCommand();
execExtendSelectionForwardByLineCommand();
-// FIXME: This is wrong. The pre tags get copied when they shouldn't be.
+// FIXME: This is wrong. The pre tags get copied when they shouldn't be.
// See https://bugs.webkit.org/show_bug.cgi?id=42009
document.execCommand("indent");
document.getElementById("results").innerText = "PASSED (did not crash)";
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/editing/execCommand/indent-pre-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698