Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1778683004: CLI support for `enableConditionalDirectives`. (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, sethladd
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : typos #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 1 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 9 months ago (2016-03-09 03:17:03 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1778683004/diff/20001/pkg/analyzer_cli/test/options_test.dart File pkg/analyzer_cli/test/options_test.dart (right): https://codereview.chromium.org/1778683004/diff/20001/pkg/analyzer_cli/test/options_test.dart#newcode28 pkg/analyzer_cli/test/options_test.dart:28: expect(options.enableConditionalDirectives, isFalse); Maybe a test showing that it's ...
4 years, 9 months ago (2016-03-09 03:31:10 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1778683004/diff/20001/pkg/analyzer_cli/test/options_test.dart File pkg/analyzer_cli/test/options_test.dart (right): https://codereview.chromium.org/1778683004/diff/20001/pkg/analyzer_cli/test/options_test.dart#newcode28 pkg/analyzer_cli/test/options_test.dart:28: expect(options.enableConditionalDirectives, isFalse); On 2016/03/09 03:31:10, Brian Wilkerson wrote: ...
4 years, 9 months ago (2016-03-09 18:04:32 UTC) #4
pquitslund
4 years, 9 months ago (2016-03-09 18:04:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb3eae598a29c277639ee74eb565e87ad569d13d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698