Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1778673005: cc: ImageDecodes: Remove ref counting from SIDC::DecodedImage. (Closed)

Created:
4 years, 9 months ago by vmpstr
Modified:
4 years, 9 months ago
Reviewers:
enne (OOO), ericrk
CC:
chromium-reviews, tfarina, cc-bugs_chromium.org, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: ImageDecodes: Remove ref counting from SIDC::DecodedImage. This patch removes ref counting from DecodedImage class in SoftwareImageDecodeController. BUG=592823 R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/61c1b9da83fd9783d23421735c6a777899c6b127 Cr-Commit-Position: refs/heads/master@{#380789}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M cc/tiles/software_image_decode_controller.h View 4 chunks +6 lines, -11 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 11 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
vmpstr
Please take a look. This depends on https://codereview.chromium.org/1763273002/
4 years, 9 months ago (2016-03-09 21:59:39 UTC) #2
ericrk
lgtm
4 years, 9 months ago (2016-03-09 23:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778673005/20001
4 years, 9 months ago (2016-03-10 19:18:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179501)
4 years, 9 months ago (2016-03-10 20:12:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778673005/20001
4 years, 9 months ago (2016-03-11 00:04:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/138178)
4 years, 9 months ago (2016-03-11 00:42:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778673005/20001
4 years, 9 months ago (2016-03-11 01:33:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129303)
4 years, 9 months ago (2016-03-11 02:18:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778673005/20001
4 years, 9 months ago (2016-03-11 18:42:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/188139)
4 years, 9 months ago (2016-03-11 21:58:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778673005/20001
4 years, 9 months ago (2016-03-11 22:13:16 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 23:55:46 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 23:58:34 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61c1b9da83fd9783d23421735c6a777899c6b127
Cr-Commit-Position: refs/heads/master@{#380789}

Powered by Google App Engine
This is Rietveld 408576698