Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.h

Issue 1778663007: MD Settings: break SettingsPageUIHandler to its own file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-nits
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_ui.h
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.h b/chrome/browser/ui/webui/settings/md_settings_ui.h
index 72ca4f3c2df24779425087b31a8ef33c8df9a06a..9e9c68ed15eb0c8f6248f4ea679f31cd99cce5b9 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui.h
+++ b/chrome/browser/ui/webui/settings/md_settings_ui.h
@@ -5,47 +5,16 @@
#ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_MD_SETTINGS_UI_H_
#define CHROME_BROWSER_UI_WEBUI_SETTINGS_MD_SETTINGS_UI_H_
-#include <string>
#include <vector>
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "base/time/time.h"
-#include "base/values.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_ui_controller.h"
-#include "content/public/browser/web_ui_message_handler.h"
namespace settings {
-// The base class handler of Javascript messages of settings pages.
-class SettingsPageUIHandler : public content::WebUIMessageHandler {
- public:
- SettingsPageUIHandler();
- ~SettingsPageUIHandler() override;
-
- // WebUIMessageHandler implementation.
- void RegisterMessages() override {}
-
- // TODO(dbeam): move to WebUIMessageHandler?
- virtual void RenderViewReused() {}
-
- protected:
- // Helper method for responding to JS requests initiated with
- // cr.sendWithPromise(), for the case where the returned promise should be
- // resolved (request succeeded).
- void ResolveJavascriptCallback(const base::Value& callback_id,
- const base::Value& response);
-
- // Helper method for responding to JS requests initiated with
- // cr.sendWithPromise(), for the case where the returned promise should be
- // rejected (request failed).
- void RejectJavascriptCallback(const base::Value& callback_id,
- const base::Value& response);
-
- private:
- DISALLOW_COPY_AND_ASSIGN(SettingsPageUIHandler);
-};
+class SettingsPageUIHandler;
// The WebUI handler for chrome://md-settings.
class MdSettingsUI : public content::WebUIController,

Powered by Google App Engine
This is Rietveld 408576698