Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1778663007: MD Settings: break SettingsPageUIHandler to its own file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-nits
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/webui/settings/appearance_handler.h" 13 #include "chrome/browser/ui/webui/settings/appearance_handler.h"
14 #include "chrome/browser/ui/webui/settings/downloads_handler.h" 14 #include "chrome/browser/ui/webui/settings/downloads_handler.h"
15 #include "chrome/browser/ui/webui/settings/font_handler.h" 15 #include "chrome/browser/ui/webui/settings/font_handler.h"
16 #include "chrome/browser/ui/webui/settings/languages_handler.h" 16 #include "chrome/browser/ui/webui/settings/languages_handler.h"
17 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 17 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
18 #include "chrome/browser/ui/webui/settings/people_handler.h" 18 #include "chrome/browser/ui/webui/settings/people_handler.h"
19 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h" 19 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h"
20 #include "chrome/browser/ui/webui/settings/search_engines_handler.h" 20 #include "chrome/browser/ui/webui/settings/search_engines_handler.h"
21 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h" 21 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"
22 #include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"
22 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h" 23 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h"
23 #include "chrome/browser/ui/webui/settings/site_settings_handler.h" 24 #include "chrome/browser/ui/webui/settings/site_settings_handler.h"
24 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
25 #include "content/public/browser/web_contents.h" 26 #include "content/public/browser/web_contents.h"
26 #include "content/public/browser/web_ui.h" 27 #include "content/public/browser/web_ui.h"
27 #include "content/public/browser/web_ui_data_source.h" 28 #include "content/public/browser/web_ui_data_source.h"
28 #include "grit/settings_resources.h" 29 #include "grit/settings_resources.h"
29 #include "grit/settings_resources_map.h" 30 #include "grit/settings_resources_map.h"
30 31
31 #if defined(OS_CHROMEOS) 32 #if defined(OS_CHROMEOS)
32 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h" 33 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"
33 #include "chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h" 34 #include "chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h"
34 #include "chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler .h" 35 #include "chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler .h"
35 #else // !defined(OS_CHROMEOS) 36 #else // !defined(OS_CHROMEOS)
36 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h" 37 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h"
37 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h" 38 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
38 #endif // defined(OS_CHROMEOS) 39 #endif // defined(OS_CHROMEOS)
39 40
40 #if defined(USE_NSS_CERTS) 41 #if defined(USE_NSS_CERTS)
41 #include "chrome/browser/ui/webui/settings/certificates_handler.h" 42 #include "chrome/browser/ui/webui/settings/certificates_handler.h"
42 #endif // defined(USE_NSS_CERTS) 43 #endif // defined(USE_NSS_CERTS)
43 44
44 namespace settings { 45 namespace settings {
45 46
46 SettingsPageUIHandler::SettingsPageUIHandler() {
47 }
48
49 SettingsPageUIHandler::~SettingsPageUIHandler() {
50 }
51
52 void SettingsPageUIHandler::ResolveJavascriptCallback(
53 const base::Value& callback_id,
54 const base::Value& response) {
55 // cr.webUIResponse is a global JS function exposed from cr.js.
56 web_ui()->CallJavascriptFunction(
57 "cr.webUIResponse", callback_id,
58 base::FundamentalValue(true), response);
59 }
60
61 void SettingsPageUIHandler::RejectJavascriptCallback(
62 const base::Value& callback_id,
63 const base::Value& response) {
64 // cr.webUIResponse is a global JS function exposed from cr.js.
65 web_ui()->CallJavascriptFunction(
66 "cr.webUIResponse", callback_id,
67 base::FundamentalValue(false), response);
68 }
69
70 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui) 47 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)
71 : content::WebUIController(web_ui), 48 : content::WebUIController(web_ui),
72 WebContentsObserver(web_ui->GetWebContents()) { 49 WebContentsObserver(web_ui->GetWebContents()) {
73 Profile* profile = Profile::FromWebUI(web_ui); 50 Profile* profile = Profile::FromWebUI(web_ui);
74 AddSettingsPageUIHandler(new AppearanceHandler(web_ui)); 51 AddSettingsPageUIHandler(new AppearanceHandler(web_ui));
75 52
76 #if defined(USE_NSS_CERTS) 53 #if defined(USE_NSS_CERTS)
77 AddSettingsPageUIHandler(new CertificatesHandler(false)); 54 AddSettingsPageUIHandler(new CertificatesHandler(false));
78 #endif // defined(USE_NSS_CERTS) 55 #endif // defined(USE_NSS_CERTS)
79 56
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD", 125 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD",
149 base::Time::Now() - load_start_time_); 126 base::Time::Now() - load_start_time_);
150 } 127 }
151 128
152 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() { 129 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() {
153 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD", 130 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD",
154 base::Time::Now() - load_start_time_); 131 base::Time::Now() - load_start_time_);
155 } 132 }
156 133
157 } // namespace settings 134 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698