Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778663007: MD Settings: break SettingsPageUIHandler to its own file (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
asanka, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-downloads_chromium.org, michaelpg+watch-md-settings_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@startup-nits
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: break SettingsPageUIHandler to its own file This is because both: * a 1-to-1 file-to-class model in more common in Chromium * it's not clear that md_settings_ui.h bring in SettingsPageUIHandler nor that it's a useful #include R=dpapad@chromium.org BUG=none Committed: https://crrev.com/7cbbde4df671db57cf16d222f800f430bd5b13f2 Cr-Commit-Position: refs/heads/master@{#380667}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : add back forward #

Patch Set 4 : copyright #

Patch Set 5 : compile fix #

Patch Set 6 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -74 lines) Patch
M chrome/browser/ui/webui/settings/appearance_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/downloads_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/font_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/languages_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.h View 1 2 1 chunk +1 line, -33 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/reset_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/search_engines_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/settings_default_browser_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/webui/settings/settings_page_ui_handler.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/settings/settings_page_ui_handler.cc View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_startup_pages_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1777173002 Patch 40001

Messages

Total messages: 9 (3 generated)
Dan Beam
4 years, 9 months ago (2016-03-10 02:52:53 UTC) #1
dpapad
LGTM. Probably need to resolve conflicts though. https://codereview.chromium.org/1778663007/diff/1/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc File chrome/browser/ui/webui/settings/settings_page_ui_handler.cc (right): https://codereview.chromium.org/1778663007/diff/1/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc#newcode1 chrome/browser/ui/webui/settings/settings_page_ui_handler.cc:1: // Copyright ...
4 years, 9 months ago (2016-03-10 18:04:47 UTC) #2
Dan Beam
https://codereview.chromium.org/1778663007/diff/1/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc File chrome/browser/ui/webui/settings/settings_page_ui_handler.cc (right): https://codereview.chromium.org/1778663007/diff/1/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc#newcode1 chrome/browser/ui/webui/settings/settings_page_ui_handler.cc:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 9 months ago (2016-03-11 06:38:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663007/100001
4 years, 9 months ago (2016-03-11 17:20:45 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-11 17:54:22 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 17:57:00 UTC) #9
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/7cbbde4df671db57cf16d222f800f430bd5b13f2
Cr-Commit-Position: refs/heads/master@{#380667}

Powered by Google App Engine
This is Rietveld 408576698