Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: pkg/analysis_server/lib/src/status/validator.dart

Issue 1778663006: Clean up some warnings (issue 25964) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/edit/fixes_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/status/validator.dart
diff --git a/pkg/analysis_server/lib/src/status/validator.dart b/pkg/analysis_server/lib/src/status/validator.dart
index 5651b8e3ccbb2cf1981bd6175d26fb26d4ca0417..9fff915e989805ff5806a076c16aeb177e4c37b2 100644
--- a/pkg/analysis_server/lib/src/status/validator.dart
+++ b/pkg/analysis_server/lib/src/status/validator.dart
@@ -422,14 +422,14 @@ class ElementComparator {
_write('; found ');
_writeln(actual.nameOffset);
}
- SourceRange expectedRange = expected.docRange;
- SourceRange actualRange = actual.docRange;
- if (expectedRange.offset != actualRange.offset ||
- expectedRange.length != actualRange.length) {
- _write('Expected documentation range of ');
- _write(expectedRange);
- _write('; found ');
- _writeln(actualRange);
+ String expectedComment = expected.documentationComment;
+ String actualComment = actual.documentationComment;
+ if (expectedComment != actualComment) {
+ _write('Expected documentation comment of "');
+ _write(expectedComment);
+ _write('"; found "');
+ _write(actualComment);
+ _writeln('"');
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/edit/fixes_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698