Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1778663006: Clean up some warnings (issue 25964) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-10 01:26:03 UTC) #3
scheglov
LGTM
4 years, 9 months ago (2016-03-10 01:28:00 UTC) #4
Brian Wilkerson
4 years, 9 months ago (2016-03-10 01:32:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef1c632679119b66ac9d255ac480b14529b25654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698