Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1778663004: Parallelize test/mjsunit/es6/tail-call-megatest.js in order to avoid timeouts on slow architectures. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parallelize test/mjsunit/es6/tail-call-megatest.js in order to avoid timeouts on slow architectures. Committed: https://crrev.com/209eb337b17590a14f9a9d2d5d6c620f5c2e1d24 Cr-Commit-Position: refs/heads/master@{#34622}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -2 lines) Patch
M test/mjsunit/es6/tail-call-megatest.js View 4 chunks +12 lines, -2 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard0.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard1.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard2.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard3.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard4.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard5.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard6.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard7.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard8.js View 1 chunk +15 lines, -0 lines 0 comments Download
A test/mjsunit/es6/tail-call-megatest-shard9.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663004/1
4 years, 9 months ago (2016-03-09 13:10:58 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-09 13:11:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 13:33:45 UTC) #6
Michael Starzinger
LGTM with one suggestion. https://codereview.chromium.org/1778663004/diff/1/test/mjsunit/es6/tail-call-megatest.js File test/mjsunit/es6/tail-call-megatest.js (right): https://codereview.chromium.org/1778663004/diff/1/test/mjsunit/es6/tail-call-megatest.js#newcode42 test/mjsunit/es6/tail-call-megatest.js:42: var SHARDS_COUNT = 10; suggestion: ...
4 years, 9 months ago (2016-03-09 13:37:05 UTC) #7
Michael Starzinger
Also, it might be better to remove the "all" test case and just shard on ...
4 years, 9 months ago (2016-03-09 13:38:26 UTC) #8
Igor Sheludko
I removed the all test. Thanks. https://codereview.chromium.org/1778663004/diff/1/test/mjsunit/es6/tail-call-megatest.js File test/mjsunit/es6/tail-call-megatest.js (right): https://codereview.chromium.org/1778663004/diff/1/test/mjsunit/es6/tail-call-megatest.js#newcode42 test/mjsunit/es6/tail-call-megatest.js:42: var SHARDS_COUNT = ...
4 years, 9 months ago (2016-03-09 13:43:12 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663004/20001
4 years, 9 months ago (2016-03-09 13:43:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663004/20001
4 years, 9 months ago (2016-03-09 13:57:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663004/20001
4 years, 9 months ago (2016-03-09 14:05:56 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 14:07:40 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 14:09:07 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/209eb337b17590a14f9a9d2d5d6c620f5c2e1d24
Cr-Commit-Position: refs/heads/master@{#34622}

Powered by Google App Engine
This is Rietveld 408576698