Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177863007: Replace WebDocument::clearfocusedNode to clearFocusedElement (Closed)

Created:
6 years, 10 months ago by maheshkk
Modified:
6 years, 10 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, jam, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace WebDocument::clearfocusedNode to clearFocusedElement WebDocument::clearFocusedNode is a deprecated Api, move chromium to new api clearFocusedElement. BUG=258763 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253652

Patch Set 1 #

Patch Set 2 : rebased with latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
maheshkk
PTAL
6 years, 10 months ago (2014-02-26 06:24:11 UTC) #1
jam
lgtm
6 years, 10 months ago (2014-02-26 17:49:37 UTC) #2
maheshkk
On 2014/02/26 17:49:37, jam wrote: > lgtm Thank for the review jam!
6 years, 10 months ago (2014-02-26 19:21:41 UTC) #3
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 10 months ago (2014-02-26 19:21:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/177863007/20001
6 years, 10 months ago (2014-02-26 19:23:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 19:47:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=52204
6 years, 10 months ago (2014-02-26 19:47:13 UTC) #7
maheshkk
Missing LGTM from an OWNER for these files: content/common/view_messages.h palmer, tsepez could you please take ...
6 years, 10 months ago (2014-02-26 19:54:17 UTC) #8
Tom Sepez
Messages LGTM.
6 years, 10 months ago (2014-02-26 19:55:31 UTC) #9
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 10 months ago (2014-02-26 19:57:19 UTC) #10
maheshkk
On 2014/02/26 19:55:31, Tom Sepez wrote: > Messages LGTM. Thanks Tom!
6 years, 10 months ago (2014-02-26 19:57:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/177863007/20001
6 years, 10 months ago (2014-02-26 20:01:37 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-27 00:21:02 UTC) #13
Message was sent while issue was closed. 
Change committed as 253652

Powered by Google App Engine
This is Rietveld 408576698