components/nacl/browser/nacl_broker_host_win.cc - Issue 177863002: Refactor configuration of sandboxes - first steps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_broker_host_win.cc

Issue 177863002: Refactor configuration of sandboxes - first steps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to review comments from jam@ Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/nacl_broker_host_win.cc

diff --git a/components/nacl/browser/nacl_broker_host_win.cc b/components/nacl/browser/nacl_broker_host_win.cc

index ca54e6759ec1888b31a746cccaabbea455fadff2..f42cb7f139d74ba30c8fda5f898cc384b982b4a4 100644

--- a/components/nacl/browser/nacl_broker_host_win.cc

+++ b/components/nacl/browser/nacl_broker_host_win.cc

@@ -28,8 +28,8 @@ class NaClBrokerSandboxedProcessLauncherDelegate

NaClBrokerSandboxedProcessLauncherDelegate() {}

virtual ~NaClBrokerSandboxedProcessLauncherDelegate() {}

- virtual void ShouldSandbox(bool* in_sandbox) OVERRIDE {

- *in_sandbox = false;

+ virtual bool ShouldSandbox() OVERRIDE {

+ return false;

}

private:

@@ -68,7 +68,6 @@ bool NaClBrokerHost::Init() {

cmd_line->AppendSwitch(switches::kNoErrorDialogs);

process_->Launch(new NaClBrokerSandboxedProcessLauncherDelegate,

- false,

cmd_line);

return true;

}