Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: lib/src/options.dart

Issue 1778623002: DDC: remove dumpInfo flag (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler.dart ('k') | lib/src/server/server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 5a4fcb3deebf45632aa195ee910bedf5a7df5630..3abd97582b0bbee7a97ecb815517daebe1660369 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -123,15 +123,8 @@ class CompilerOptions {
/// Whether to check the sdk libraries.
final bool checkSdk;
- /// Whether to dump summary information on the console.
- final bool dumpInfo;
-
final bool htmlReport;
- /// If not null, path to a file that will store a json representation of the
- /// summary information (only used if [dumpInfo] is true).
- final String dumpInfoFile;
-
/// Whether to use colors when interacting on the console.
final bool useColors;
@@ -176,9 +169,7 @@ class CompilerOptions {
this.codegenOptions: const CodegenOptions(),
this.runnerOptions: const RunnerOptions(),
this.checkSdk: false,
- this.dumpInfo: false,
this.htmlReport: false,
- this.dumpInfoFile,
this.useColors: true,
this.help: false,
this.version: false,
@@ -224,9 +215,6 @@ CompilerOptions parseOptions(List<String> argv, {bool forceOutDir: false}) {
if (outputDir == null && (serverMode || forceOutDir)) {
outputDir = Directory.systemTemp.createTempSync("dev_compiler_out_").path;
}
- var dumpInfo = args['dump-info'];
- if (dumpInfo == null) dumpInfo = serverMode;
-
var htmlReport = args['html-report'];
var v8Binary = args['v8-binary'];
@@ -264,9 +252,7 @@ CompilerOptions parseOptions(List<String> argv, {bool forceOutDir: false}) {
args['resources'].split(',').where((s) => s.isNotEmpty).toList()),
runnerOptions: new RunnerOptions(v8Binary: v8Binary),
checkSdk: args['sdk-check'],
- dumpInfo: dumpInfo,
htmlReport: htmlReport,
- dumpInfoFile: args['dump-info-file'],
useColors: useColors,
help: showUsage,
version: showVersion,
« no previous file with comments | « lib/src/compiler.dart ('k') | lib/src/server/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698