Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1778493005: Inline calling into the interceptor into the IC callbacks rather than going through the LookupItera… (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline calling into the interceptor into the IC callbacks rather than going through the LookupIterator. This is highly performance sensitive as there is no faster path; it's used directly by the IC. BUG=chromium:592305 LOG=n Committed: https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644 Cr-Commit-Position: refs/heads/master@{#34660}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -28 lines) Patch
M src/ic/handler-compiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 2 chunks +48 lines, -11 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 1 comment Download
M src/objects.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +20 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-09 16:34:52 UTC) #2
Jakob Kummerow
LGTM. The duplication of code is unfortunate, but it makes sense to speed up this ...
4 years, 9 months ago (2016-03-10 09:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778493005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778493005/40001
4 years, 9 months ago (2016-03-10 10:24:10 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 10:55:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 10:56:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79ccf34a78ea0e266e3a36ed63649ef49121f644
Cr-Commit-Position: refs/heads/master@{#34660}

Powered by Google App Engine
This is Rietveld 408576698