Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1778483002: Remove special-code for removing anonymous blocks around pseudo elements. (Closed)

Created:
4 years, 9 months ago by mstensho (USE GERRIT)
Modified:
4 years, 9 months ago
Reviewers:
rhogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special-code for removing anonymous blocks around pseudo elements. We now have more generic code to take care of this, in makeChildrenInlineIfPossible(). Committed: https://crrev.com/e08a8bd2497b9b7135f03d64e70be59ca40b6736 Cr-Commit-Position: refs/heads/master@{#380617}

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mstensho (USE GERRIT)
4 years, 9 months ago (2016-03-09 20:30:41 UTC) #2
mstensho (USE GERRIT)
@eae @rhogan: ping
4 years, 9 months ago (2016-03-10 19:08:45 UTC) #3
eae
LGTM
4 years, 9 months ago (2016-03-10 19:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778483002/1
4 years, 9 months ago (2016-03-10 19:13:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/143234) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 19:17:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778483002/20001
4 years, 9 months ago (2016-03-11 10:11:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 13:18:08 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 13:19:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e08a8bd2497b9b7135f03d64e70be59ca40b6736
Cr-Commit-Position: refs/heads/master@{#380617}

Powered by Google App Engine
This is Rietveld 408576698