Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1778473002: MacViews: Fix failing bubble border tests after r375729. (Closed)

Created:
4 years, 9 months ago by karandeepb
Modified:
4 years, 9 months ago
Reviewers:
tapted, msw
CC:
chromium-reviews, tfarina, msw+watch_chromium.org, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, rouslan+bubble_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix failing bubble border tests after r375729. r375729 changed all the bubble borders on MacViews to use BubbleBorder::NO_ASSETS. This caused the following tests to regress- BubbleBorderTest.GetBoundsOriginTest BubbleBorderTest.GetSizeForContentsSizeTest These tests regressed since they use kImages->top_arrow which is not set for BubbleBorder::NO_ASSETS. This CL fixes these tests by using kImages->arrow_width instead. BUG=592856 Committed: https://crrev.com/6e2dad5dbc48da995987c7c4e27d419a9879fd83 Cr-Commit-Position: refs/heads/master@{#379981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/views/bubble/bubble_border_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
karandeepb
PTAL Trent. Thanks.
4 years, 9 months ago (2016-03-08 23:16:05 UTC) #3
tapted
lgtm
4 years, 9 months ago (2016-03-08 23:17:28 UTC) #4
karandeepb
+msw@ for owner's review.
4 years, 9 months ago (2016-03-08 23:20:56 UTC) #6
msw
lgtm
4 years, 9 months ago (2016-03-08 23:25:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778473002/1
4 years, 9 months ago (2016-03-08 23:29:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 23:56:19 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:57:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e2dad5dbc48da995987c7c4e27d419a9879fd83
Cr-Commit-Position: refs/heads/master@{#379981}

Powered by Google App Engine
This is Rietveld 408576698