Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1778463002: Remove special-code used by the old (removed) multicol implementation. (Closed)

Created:
4 years, 9 months ago by mstensho (USE GERRIT)
Modified:
4 years, 9 months ago
Reviewers:
rhogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. Committed: https://crrev.com/8a846777c358c69996d5143f99e869014a1940cb Cr-Commit-Position: refs/heads/master@{#380381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +12 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mstensho (USE GERRIT)
4 years, 9 months ago (2016-03-09 20:30:08 UTC) #4
eae
Very nice, tack sa mycket! LGTM
4 years, 9 months ago (2016-03-09 21:13:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778463002/1
4 years, 9 months ago (2016-03-09 21:14:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/186645)
4 years, 9 months ago (2016-03-10 01:05:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778463002/1
4 years, 9 months ago (2016-03-10 07:44:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 09:19:48 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 09:21:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a846777c358c69996d5143f99e869014a1940cb
Cr-Commit-Position: refs/heads/master@{#380381}

Powered by Google App Engine
This is Rietveld 408576698