Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by mstensho (USE GERRIT) Modified:
4 years, 9 months ago Reviewers:
rhogan, eae CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove special-code used by the old (removed) multicol implementation.
In regular block flow, anonymous blocks always have inline children, unless
it's the part of a continuation chain that contains blocks (which should never
be merged with siblings). Anonymous blocks with block-children also occur in
flexbox (flex items), and in the ruby implementation, but otherwise never in
regular block container layout.
Committed: https://crrev.com/8a846777c358c69996d5143f99e869014a1940cb
Cr-Commit-Position: refs/heads/master@{#380381}
Patch Set 1 #
Created: 4 years, 9 months ago
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Remove special code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ========== to ========== Remove special code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ==========
Description was changed from ========== Remove special code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ========== to ========== Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ==========
mstensho@opera.com changed reviewers: + eae@chromium.org, robhogan@gmail.com
Very nice, tack sa mycket! LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778463002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778463002/1
Message was sent while issue was closed.
Description was changed from ========== Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ========== to ========== Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. ========== to ========== Remove special-code used by the old (removed) multicol implementation. In regular block flow, anonymous blocks always have inline children, unless it's the part of a continuation chain that contains blocks (which should never be merged with siblings). Anonymous blocks with block-children also occur in flexbox (flex items), and in the ruby implementation, but otherwise never in regular block container layout. Committed: https://crrev.com/8a846777c358c69996d5143f99e869014a1940cb Cr-Commit-Position: refs/heads/master@{#380381} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a846777c358c69996d5143f99e869014a1940cb Cr-Commit-Position: refs/heads/master@{#380381} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
