Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (patchset #2 id:60001 of https://codereview.chromium.org/1699763002/ )
Reason for revert:
This change breaks Print Preview. See crbug/592878.
Original issue's description:
> [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
>
> Currently only constrained web dialogs for views (Linux/Windows) are able to
> autoresize. This change implements the option to pass in minimum and maximum
> sizes and enabling autoresizing functionality for OSX.
>
> This change adds two static functions for options on whether to create a
> ConstrainedWindowsMac that autoresizes or is of fixed size.
>
> The first two patches were reverted because of flaky tests on Mac 10.9.
>
> Those patches can be found at:
> 1. https://codereview.chromium.org/1430023002
> 2. https://codereview.chromium.org/1446623003
>
> After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585.
>
> The patch to disable occlusion notifications can be found at:
> https://codereview.chromium.org/1762883002/
>
> BUG=217034
>
> Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de
> Cr-Commit-Position: refs/heads/master@{#379512}
TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=217034
Committed: https://crrev.com/df2a787f7d4f8e01c171886ed977c051fefb5413
Cr-Commit-Position: refs/heads/master@{#379776}
Created Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
4 years, 9 months ago
(2016-03-08 06:57:36 UTC)
#1
Created Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for
Mac.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago
(2016-03-08 06:57:49 UTC)
#2
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago
(2016-03-08 07:01:22 UTC)
#3
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago
(2016-03-08 07:31:23 UTC)
#4
4 years, 9 months ago
(2016-03-08 07:42:37 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for ...
4 years, 9 months ago
(2016-03-08 07:44:16 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
(patchset #2 id:60001 of https://codereview.chromium.org/1699763002/ )
Reason for revert:
This change breaks Print Preview. See crbug/592878.
Original issue's description:
> [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
>
> Currently only constrained web dialogs for views (Linux/Windows) are able to
> autoresize. This change implements the option to pass in minimum and maximum
> sizes and enabling autoresizing functionality for OSX.
>
> This change adds two static functions for options on whether to create a
> ConstrainedWindowsMac that autoresizes or is of fixed size.
>
> The first two patches were reverted because of flaky tests on Mac 10.9.
>
> Those patches can be found at:
> 1. https://codereview.chromium.org/1430023002
> 2. https://codereview.chromium.org/1446623003
>
> After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.
>
> The patch to disable occlusion notifications can be found at:
> https://codereview.chromium.org/1762883002/
>
> BUG=217034
>
> Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de
> Cr-Commit-Position: refs/heads/master@{#379512}
TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=217034
==========
to
==========
Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
(patchset #2 id:60001 of https://codereview.chromium.org/1699763002/ )
Reason for revert:
This change breaks Print Preview. See crbug/592878.
Original issue's description:
> [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
>
> Currently only constrained web dialogs for views (Linux/Windows) are able to
> autoresize. This change implements the option to pass in minimum and maximum
> sizes and enabling autoresizing functionality for OSX.
>
> This change adds two static functions for options on whether to create a
> ConstrainedWindowsMac that autoresizes or is of fixed size.
>
> The first two patches were reverted because of flaky tests on Mac 10.9.
>
> Those patches can be found at:
> 1. https://codereview.chromium.org/1430023002
> 2. https://codereview.chromium.org/1446623003
>
> After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.
>
> The patch to disable occlusion notifications can be found at:
> https://codereview.chromium.org/1762883002/
>
> BUG=217034
>
> Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de
> Cr-Commit-Position: refs/heads/master@{#379512}
TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=217034
Committed: https://crrev.com/df2a787f7d4f8e01c171886ed977c051fefb5413
Cr-Commit-Position: refs/heads/master@{#379776}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df2a787f7d4f8e01c171886ed977c051fefb5413 Cr-Commit-Position: refs/heads/master@{#379776}
4 years, 9 months ago
(2016-03-08 07:44:17 UTC)
#7
Issue 1778453002: Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
(Closed)
Created 4 years, 9 months ago by apacible
Modified 4 years, 9 months ago
Reviewers: Nico
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0