Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1778453002: Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (patchset #2 id:60001 of https://codereview.chromium.org/1699763002/ ) Reason for revert: This change breaks Print Preview. See crbug/592878. Original issue's description: > [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. > > Currently only constrained web dialogs for views (Linux/Windows) are able to > autoresize. This change implements the option to pass in minimum and maximum > sizes and enabling autoresizing functionality for OSX. > > This change adds two static functions for options on whether to create a > ConstrainedWindowsMac that autoresizes or is of fixed size. > > The first two patches were reverted because of flaky tests on Mac 10.9. > > Those patches can be found at: > 1. https://codereview.chromium.org/1430023002 > 2. https://codereview.chromium.org/1446623003 > > After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585. > > The patch to disable occlusion notifications can be found at: > https://codereview.chromium.org/1762883002/ > > BUG=217034 > > Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de > Cr-Commit-Position: refs/heads/master@{#379512} TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=217034 Committed: https://crrev.com/df2a787f7d4f8e01c171886ed977c051fefb5413 Cr-Commit-Position: refs/heads/master@{#379776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -319 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 8 chunks +18 lines, -139 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 4 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +8 lines, -42 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 6 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 7 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
apacible
Created Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
4 years, 9 months ago (2016-03-08 06:57:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago (2016-03-08 06:57:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago (2016-03-08 07:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778453002/1
4 years, 9 months ago (2016-03-08 07:31:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 07:42:37 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 07:44:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2a787f7d4f8e01c171886ed977c051fefb5413
Cr-Commit-Position: refs/heads/master@{#379776}

Powered by Google App Engine
This is Rietveld 408576698