Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177843004: Don't lookup touchscreen info for XIMasterPointer. (Closed)

Created:
6 years, 10 months ago by tdresser
Modified:
6 years, 10 months ago
Reviewers:
sadrul, haltonhuo
CC:
chromium-reviews
Visibility:
Public.

Description

Don't lookup touchscreen info for XIMasterPointer. This fixes a crash caused by calling XOpenDevice on the core pointer. BUG=343488 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ui/events/x/touch_factory_x11.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
tdresser
Untested, as I haven't been able to reproduce the issue locally. Sadrul, can you give ...
6 years, 10 months ago (2014-02-24 21:17:32 UTC) #1
sadrul
Tested locally. Fixes the issue for me. LGTM
6 years, 10 months ago (2014-02-24 21:20:07 UTC) #2
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-24 21:23:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-24 21:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 01:30:59 UTC) #5
haltonhuo
lgtm I've verified locally.
6 years, 10 months ago (2014-02-25 02:56:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 05:06:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 05:06:30 UTC) #8
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-25 13:50:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 13:54:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 13:55:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 13:55:50 UTC) #12
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-25 14:18:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 14:18:08 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 14:18:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 14:18:35 UTC) #16
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-25 15:06:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 15:06:51 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 15:07:33 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 15:07:34 UTC) #20
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-25 15:59:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 15:59:37 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 16:00:00 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 16:00:01 UTC) #24
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-25 19:57:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-25 19:57:56 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 19:59:52 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 19:59:53 UTC) #28
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-26 13:25:18 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/177843004/1
6 years, 10 months ago (2014-02-26 13:25:44 UTC) #30
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 13:28:59 UTC) #31
Message was sent while issue was closed. 
Change committed as 253433

Powered by Google App Engine
This is Rietveld 408576698