Don't test implementation details for invalid Link headers.

Don't test implementation details for invalid Link headers.

This changes the basic SingleLinkHeaderTest to not verify implementation
details of how LinkHeader deals with invalid headers. If a header is invalid
it doesn't matter what it's url, rel and other attributes are set to.

Also adds a missing EXPECT to compare the expected "as" attribute with the
returned "as" attribute.

Committed: https://crrev.com/bd9d199b6daf57b7b304c5cd16d6a53cba8582f5
Cr-Commit-Position: refs/heads/master@{#381790}

[Marijn Kruisselbrink, 2016-03-11 19:50:34]

Description was changed from

==========
Don't test implementation details for invalid Link headers.

This changes the baseic SingleLinkHeaderTest to not verify implementation
details of how LinkHeader deals with invalid headers. If a header is invalid
it doesn't matter what it's url, rel and other attributes are set to.

Also adds a missing EXPECT to compare the expected "as" attribute with the
returned "as" attribute.
==========

to

==========
Don't test implementation details for invalid Link headers.

This changes the basic SingleLinkHeaderTest to not verify implementation
details of how LinkHeader deals with invalid headers. If a header is invalid
it doesn't matter what it's url, rel and other attributes are set to.

Also adds a missing EXPECT to compare the expected "as" attribute with the
returned "as" attribute.
==========

[Marijn Kruisselbrink, 2016-03-11 20:35:33]

mek@chromium.org changed reviewers:
+ yoav@yoav.ws

[Marijn Kruisselbrink, 2016-03-11 20:35:34]

To make it easier to compare test results with a possible different
implementation, it seems to make sense to not compare url/rel/as attributes when
a header is supposed to be invalid anyway.
Also the "as" attribute wasn't compared at all in the existing test, so added
that.

[Marijn Kruisselbrink, 2016-03-17 18:06:56]

yoav: ping

[Yoav Weiss, 2016-03-17 19:49:45]

On 2016/03/17 18:06:56, Marijn Kruisselbrink wrote:
> yoav: ping

Sorry for the delay. LGTM

[Marijn Kruisselbrink, 2016-03-17 19:53:42]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-03-17 19:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778413005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778413005/1

[commit-bot: I haz the power, 2016-03-17 20:50:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 20:51:25]

Description was changed from

==========
Don't test implementation details for invalid Link headers.

This changes the basic SingleLinkHeaderTest to not verify implementation
details of how LinkHeader deals with invalid headers. If a header is invalid
it doesn't matter what it's url, rel and other attributes are set to.

Also adds a missing EXPECT to compare the expected "as" attribute with the
returned "as" attribute.
==========

to

==========
Don't test implementation details for invalid Link headers.

This changes the basic SingleLinkHeaderTest to not verify implementation
details of how LinkHeader deals with invalid headers. If a header is invalid
it doesn't matter what it's url, rel and other attributes are set to.

Also adds a missing EXPECT to compare the expected "as" attribute with the
returned "as" attribute.

Committed: https://crrev.com/bd9d199b6daf57b7b304c5cd16d6a53cba8582f5
Cr-Commit-Position: refs/heads/master@{#381790}
==========

[commit-bot: I haz the power, 2016-03-17 20:51:26]

Patchset 1 (id:??) landed as
https://crrev.com/bd9d199b6daf57b7b304c5cd16d6a53cba8582f5
Cr-Commit-Position: refs/heads/master@{#381790}