src/image/SkImage_Base.h - Issue 1778393002: add Make variations to return SkImage by sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Base.h

Issue 1778393002: add Make variations to return SkImage by sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: roll in fmalitas comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage_Base.h

diff --git a/src/image/SkImage_Base.h b/src/image/SkImage_Base.h

index 9e2efe98b5bd8c6a92ac5f2ae1478172ec44d055..ade891f4cb3d54ff9264af8da3a8cc256192c4af 100644

--- a/src/image/SkImage_Base.h

+++ b/src/image/SkImage_Base.h

@@ -46,7 +46,7 @@ public:

// Caller must call unref when they are done.

virtual GrTexture* asTextureRef(GrContext*, const GrTextureParams&) const = 0;

- virtual SkImage* onNewSubset(const SkIRect&) const = 0;

+ virtual sk_sp<SkImage> onMakeSubset(const SkIRect&) const = 0;

// If a ctx is specified, then only gpu-specific formats are requested.

virtual SkData* onRefEncoded(GrContext*) const { return nullptr; }