Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: src/utils/SkBitmapSourceDeserializer.cpp

Issue 1778393002: add Make variations to return SkImage by sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix no-gpu again Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/image/SkImage_Raster.cpp ('K') | « src/image/SkSurface_Raster.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/utils/SkBitmapSourceDeserializer.cpp
diff --git a/src/utils/SkBitmapSourceDeserializer.cpp b/src/utils/SkBitmapSourceDeserializer.cpp
index bb783bfeef2b9c34eaf50cbab7af7a2f890d0b68..02d3ea7402a22dced959f4f6f2e5fca9a36928e8 100644
--- a/src/utils/SkBitmapSourceDeserializer.cpp
+++ b/src/utils/SkBitmapSourceDeserializer.cpp
@@ -29,6 +29,6 @@ SkFlattenable* SkBitmapSourceDeserializer::CreateProc(SkReadBuffer& buffer) {
}
bitmap.setImmutable();
- SkAutoTUnref<SkImage> image(SkImage::NewFromBitmap(bitmap));
- return SkImageSource::Create(image, src, dst, filterQuality);
+ return SkImageSource::Create(SkImage::MakeFromBitmap(bitmap).release(),
f(malita) 2016/03/10 18:12:15 hmm, is this leaking? based on prev usage, SkImag
reed1 2016/03/10 19:12:56 GOOD CATCH!
+ src, dst, filterQuality);
}
« src/image/SkImage_Raster.cpp ('K') | « src/image/SkSurface_Raster.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698