Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 1778383002: Revert of Fix tests for check-ipc Clang plugin to pass on Windows. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
hans, dcheng, Dmitry Skiba
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix tests for check-ipc Clang plugin to pass on Windows. (patchset #2 id:20001 of https://codereview.chromium.org/1785523002/ ) Reason for revert: IPC plugin tests are failing on the clang/tot win bots. Original issue's description: > Fix tests for check-ipc Clang plugin to pass on Windows. > > Add -fno-delayed-template-parsing to disable MSVC-like behavior (check-ipc > will only be used on Android, the only platform where we need 32/64-bit > processes to talk to each other), remove test that relies on size_t being > unsigned long. > > BUG=581409 > > Committed: https://crrev.com/b9d266457c4b0b619304c99a28fce037be7b0507 > Cr-Commit-Position: refs/heads/master@{#380271} TBR=dcheng@chromium.org,hans@chromium.org,dskiba@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581409 Committed: https://crrev.com/1ae6a023e6165754ab7d9e8f5a9ed11c4e42eac8 Cr-Commit-Position: refs/heads/master@{#380407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M tools/clang/plugins/tests/ipc.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M tools/clang/plugins/tests/ipc.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/tests/ipc.txt View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Fix tests for check-ipc Clang plugin to pass on Windows.
4 years, 9 months ago (2016-03-10 15:11:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778383002/1
4 years, 9 months ago (2016-03-10 15:11:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:12:16 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:14:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ae6a023e6165754ab7d9e8f5a9ed11c4e42eac8
Cr-Commit-Position: refs/heads/master@{#380407}

Powered by Google App Engine
This is Rietveld 408576698