If under stack pressure, do not enable eager stack use.

If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515
Committed: https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7
Cr-Commit-Position: refs/heads/master@{#380426}

[sof, 2016-03-10 13:15:41]

Description was changed from

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=
BUG=
==========

to

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=
BUG=420515
==========

[sof, 2016-03-10 13:41:16]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-03-10 13:41:17]

please take a look.

( addressing
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...
)

[sof, 2016-03-10 13:43:13]

https://codereview.chromium.org/1778353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/StackFrameDepth.h (right):

https://codereview.chromium.org/1778353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/StackFrameDepth.h:37: s_stackFrameLimit
= 0;
Using 0 as the disabled limit value is strictly speaking unsafe, as it makes
isSafeToRecurse() always return true. Will address separately.

[haraken, 2016-03-10 13:43:36]

LGTM

[sof, 2016-03-10 13:46:44]

Description was changed from

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=
BUG=420515
==========

to

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515
==========

[sof, 2016-03-10 14:00:31]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-10 14:00:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001

[sof, 2016-03-10 15:40:51]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2016-03-10 15:45:24]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-10 15:45:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001

[sof, 2016-03-10 15:56:28]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2016-03-10 15:56:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-10 15:57:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001

[commit-bot: I haz the power, 2016-03-10 17:33:07]

Description was changed from

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515
==========

to

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515
==========

[commit-bot: I haz the power, 2016-03-10 17:33:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-10 17:34:36]

Description was changed from

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515
==========

to

==========
If under stack pressure, do not enable eager stack use.

The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.

This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.

R=haraken
BUG=420515

Committed: https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7
Cr-Commit-Position: refs/heads/master@{#380426}
==========

[commit-bot: I haz the power, 2016-03-10 17:34:37]

Patchset 2 (id:??) landed as
https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7
Cr-Commit-Position: refs/heads/master@{#380426}