Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by sof Modified:
4 years, 9 months ago Reviewers:
oilpan-reviews, haraken CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIf under stack pressure, do not enable eager stack use.
The Oilpan marking pass safely utilizes the system stack of the
marking thread when tracing the object graph. Should GC be
invoked when stack use is already considerable, the estimated stack
threshold for when it is no longer known safe to continue
consuming system stack, may already have been exceeded. If so,
leave the stack threshold limit & check disabled.
This addresses an assertable condition only; the stack limit
check handles GCing under stack pressure as wanted.
R=haraken
BUG=420515
Committed: https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7
Cr-Commit-Position: refs/heads/master@{#380426}
Patch Set 1 #Patch Set 2 : do not reset s_stackFrameLimit #
Total comments: 1
Created: 4 years, 9 months ago
Messages
Total messages: 18 (10 generated)
Description was changed from ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R= BUG= ========== to ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R= BUG=420515 ==========
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look. ( addressing https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db... )
https://codereview.chromium.org/1778353002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/heap/StackFrameDepth.h (right): https://codereview.chromium.org/1778353002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/heap/StackFrameDepth.h:37: s_stackFrameLimit = 0; Using 0 as the disabled limit value is strictly speaking unsafe, as it makes isSafeToRecurse() always return true. Will address separately.
LGTM
Description was changed from ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R= BUG=420515 ========== to ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R=haraken BUG=420515 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778353002/20001
Message was sent while issue was closed.
Description was changed from ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R=haraken BUG=420515 ========== to ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R=haraken BUG=420515 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R=haraken BUG=420515 ========== to ========== If under stack pressure, do not enable eager stack use. The Oilpan marking pass safely utilizes the system stack of the marking thread when tracing the object graph. Should GC be invoked when stack use is already considerable, the estimated stack threshold for when it is no longer known safe to continue consuming system stack, may already have been exceeded. If so, leave the stack threshold limit & check disabled. This addresses an assertable condition only; the stack limit check handles GCing under stack pressure as wanted. R=haraken BUG=420515 Committed: https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7 Cr-Commit-Position: refs/heads/master@{#380426} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/236e6e14f9521698f801c74d34cb0621c3ccf8d7 Cr-Commit-Position: refs/heads/master@{#380426} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
