Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1778333002: Fix corner case in iterator finalization for array destructuring. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix corner case in iterator finalization for array destructuring. The comment was correct but the code didn't match :( Must not close when .value throws. R=adamk@chromium.org BUG=v8:3566 LOG=n Committed: https://crrev.com/cd6a5a45ad9ae52ab40ee1e1681a9c64682717be Cr-Commit-Position: refs/heads/master@{#34691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -31 lines) Patch
M src/parsing/pattern-rewriter.cc View 3 chunks +47 lines, -31 lines 0 comments Download
M test/mjsunit/harmony/iterator-close.js View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
neis
4 years, 9 months ago (2016-03-10 11:03:42 UTC) #1
adamk
lgtm
4 years, 9 months ago (2016-03-10 18:51:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778333002/1
4 years, 9 months ago (2016-03-10 18:51:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 19:11:06 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:13:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6a5a45ad9ae52ab40ee1e1681a9c64682717be
Cr-Commit-Position: refs/heads/master@{#34691}

Powered by Google App Engine
This is Rietveld 408576698