Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1778313003: Revert of Move //remoting/remoting_host_win.gypi:* to GN (Closed)

Created:
4 years, 9 months ago by alexmos
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move //remoting/remoting_host_win.gypi:* to GN (patchset #7 id:120001 of https://codereview.chromium.org/1749053002/ ) Reason for revert: Seems to have broken compile on Win8 GN: https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/22702 Original issue's description: > Move //remoting/remoting_host_win.gypi:* to GN > > BUG=512899 > > Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247 > Cr-Commit-Position: refs/heads/master@{#380425} TBR=sergeyu@chromium.org,jamiewalch@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512899 Committed: https://crrev.com/43fb1cb19df40661a09651ce828baadc0efcbb12 Cr-Commit-Position: refs/heads/master@{#380429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -398 lines) Patch
M remoting/BUILD.gn View 2 chunks +4 lines, -7 lines 0 comments Download
M remoting/host/BUILD.gn View 6 chunks +8 lines, -313 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +25 lines, -58 lines 0 comments Download
D remoting/host/win/chromoting_lib.rc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/remoting_enable.gni View 1 chunk +3 lines, -3 lines 0 comments Download
A remoting/remoting_host.gni View 1 chunk +11 lines, -0 lines 0 comments Download
M remoting/remoting_host_win.gypi View 11 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alexmos
Created Revert of Move //remoting/remoting_host_win.gypi:* to GN
4 years, 9 months ago (2016-03-10 17:51:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778313003/1
4 years, 9 months ago (2016-03-10 17:52:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 17:52:47 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 17:54:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43fb1cb19df40661a09651ce828baadc0efcbb12
Cr-Commit-Position: refs/heads/master@{#380429}

Powered by Google App Engine
This is Rietveld 408576698