Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1778293004: Export Content Mus for Unit Testing (Closed)

Created:
4 years, 9 months ago by jonross
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

I am planning on adding unit tests to content/renderer/mus/ In order to link during component builds, I need to export some classes. This change adds CONTENT_EXPORT to some classes. As the mus client lib is not a component, mus base classes are not being exposed. BUG=560478 Committed: https://crrev.com/1a185fff90e864af30a7ce6a0ec6057056ddbd5f Cr-Commit-Position: refs/heads/master@{#380531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/renderer/input/input_handler_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
jonross
Hi Ben, Could you review this change? I'm exporting some classes in content/renderer so that ...
4 years, 9 months ago (2016-03-10 17:19:21 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-10 19:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778293004/1
4 years, 9 months ago (2016-03-10 20:03:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128873)
4 years, 9 months ago (2016-03-10 21:01:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778293004/1
4 years, 9 months ago (2016-03-10 23:33:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129120)
4 years, 9 months ago (2016-03-11 00:13:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778293004/1
4 years, 9 months ago (2016-03-11 02:31:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129369)
4 years, 9 months ago (2016-03-11 03:10:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778293004/1
4 years, 9 months ago (2016-03-11 03:18:42 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 05:31:03 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:32:25 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a185fff90e864af30a7ce6a0ec6057056ddbd5f
Cr-Commit-Position: refs/heads/master@{#380531}

Powered by Google App Engine
This is Rietveld 408576698