Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1778293003: Revert of "X87: Rework CallApi*Stubs." (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "X87: Rework CallApi*Stubs." Reason for revert: The original x87 related codes of the CL #34627 (https://codereview.chromium.org/1748123003) had a mistake and caused the x87 debug build fail. Need to fix it and add it into the x87 port of the CL #34627 BUG= Committed: https://crrev.com/cf959c4b415e04e791229a223ca5fbf2bb47a73c Cr-Commit-Position: refs/heads/master@{#34679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-10 14:12:03 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-10 14:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778293003/1
4 years, 9 months ago (2016-03-10 14:25:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 14:47:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 14:48:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf959c4b415e04e791229a223ca5fbf2bb47a73c
Cr-Commit-Position: refs/heads/master@{#34679}

Powered by Google App Engine
This is Rietveld 408576698